RubyGems - activesupport - Versions diffs - 8.0.0.beta1 → 8.0.0.rc1 - Mend

activesupport 8.0.0.beta1 → 8.0.0.rc1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (20) hide show

checksums.yaml +4 -4
data/CHANGELOG.md +38 -0
data/lib/active_support/core_ext/module/attr_internal.rb +3 -4
data/lib/active_support/core_ext/thread/backtrace/location.rb +2 -7
data/lib/active_support/delegation.rb +0 -2
data/lib/active_support/dependencies.rb +0 -1
data/lib/active_support/deprecation/reporting.rb +0 -19
data/lib/active_support/duration.rb +14 -10
data/lib/active_support/evented_file_update_checker.rb +0 -1
data/lib/active_support/gem_version.rb +1 -1
data/lib/active_support/hash_with_indifferent_access.rb +0 -4
data/lib/active_support/i18n_railtie.rb +2 -3
data/lib/active_support/isolated_execution_state.rb +0 -1
data/lib/active_support/notifications/fanout.rb +0 -1
data/lib/active_support/testing/assertions.rb +17 -10
data/lib/active_support/testing/strict_warnings.rb +1 -1
data/lib/active_support/values/time_zone.rb +6 -6
data/lib/active_support.rb +0 -1
metadata +5 -6
data/lib/active_support/proxy_object.rb +0 -20

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 492cd4c9d2ec59d97060d7949b3b68badc089d97ea467a30a0e6614d65e69c21
-  data.tar.gz: 98af51f7ec102b694fbd17f636cdf942b965a9a845561f05b1569b07efc56747
+  metadata.gz: e51398b1109b9d7cbf736ee05a1bbae3b4239b163ffc32e6d72efff689a8681d
+  data.tar.gz: d9f79afec81e5609e14bd19b71f6be93f7fa5d55c31d2a063d67b300f8cbb118
 SHA512:
-  metadata.gz: b720480df1c4117bf85c0f9066f7015dc750ca1279bba4c07a66a429effa06101adab40eda21f76c6d14ee1c57d46b6aff5cffd494e0e55d18600fe764c9d0e5
-  data.tar.gz: 13d40213e5c9720bda46e71d696a6f011547ca95ade865061df922cc9abd5adfbf6a0daa651e0732314dfb67faf3c9ad3fde39bb3490f4e3fd7577fb24b8221b
+  metadata.gz: 0c39e8b68be9fa543af24098076abe8b52001c4955d12b5cb6ed943de52d28ffdf8a381abf8c7e7438af90590739f2bbab665a02245182d50174fbbad67e8949
+  data.tar.gz: 0bdac0fa92206843c4f58e7104463e53d1fe9775db8c6a732da02aff15663063c711f958cab388059be6f8b15a2c74a3f6912a42040b70b50d5d08323dd00a2b

data/CHANGELOG.md CHANGED Viewed

@@ -1,3 +1,41 @@
+## Rails 8.0.0.rc1 (October 19, 2024) ##
+*   Remove deprecated support to passing an array of strings to `ActiveSupport::Deprecation#warn`.
+    *Rafael Mendonça França*
+*   Remove deprecated support to setting `attr_internal_naming_format` with a `@` prefix.
+    *Rafael Mendonça França*
+*   Remove deprecated `ActiveSupport::ProxyObject`.
+    *Rafael Mendonça França*
+*   Don't execute i18n watcher on boot. It shouldn't catch any file changes initially,
+    and unnecessarily slows down boot of applications with lots of translations.
+    *Gannon McGibbon*, *David Stosik*
+*   Fix `ActiveSupport::HashWithIndifferentAccess#stringify_keys` to stringify all keys not just symbols.
+    Previously:
+    ```ruby
+    { 1 => 2 }.with_indifferent_access.stringify_keys[1] # => 2
+    ```
+    After this change:
+    ```ruby
+    { 1 => 2 }.with_indifferent_access.stringify_keys["1"] # => 2
+    ```
+    This change can be seen as a bug fix, but since it behaved like this for a very long time, we're deciding
+    to not backport the fix and to make the change in a major release.
+    *Jean Boussier*
 ## Rails 8.0.0.beta1 (September 26, 2024) ##
 *   Include options when instrumenting `ActiveSupport::Cache::Store#delete` and `ActiveSupport::Cache::Store#delete_multi`.

data/lib/active_support/core_ext/module/attr_internal.rb CHANGED Viewed

@@ -24,14 +24,13 @@ class Module
     def attr_internal_naming_format=(format)
       if format.start_with?("@")
-        ActiveSupport.deprecator.warn <<~MESSAGE
-          Setting `attr_internal_naming_format` with a `@` prefix is deprecated and will be removed in Rails 8.0.
+        raise ArgumentError, <<~MESSAGE.squish
+          Setting `attr_internal_naming_format` with a `@` prefix is not supported.
           You can simply replace #{format.inspect} by #{format.delete_prefix("@").inspect}.
         MESSAGE
-        format = format.delete_prefix("@")
       end
       @attr_internal_naming_format = format
     end
   end

data/lib/active_support/core_ext/thread/backtrace/location.rb CHANGED Viewed

@@ -1,12 +1,7 @@
 # frozen_string_literal: true
 class Thread::Backtrace::Location # :nodoc:
-  if defined?(ErrorHighlight) && Gem::Version.new(ErrorHighlight::VERSION) >= Gem::Version.new("0.4.0")
-    def spot(ex)
-      ErrorHighlight.spot(ex, backtrace_location: self)
-    end
-  else
-    def spot(ex)
-    end
+  def spot(ex)
+    ErrorHighlight.spot(ex, backtrace_location: self)
   end
 end

data/lib/active_support/delegation.rb CHANGED Viewed

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
-require "set"
 module ActiveSupport
   # Error generated by +delegate+ when a method is called on +nil+ and +allow_nil+
   # option is not used.

data/lib/active_support/dependencies.rb CHANGED Viewed

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
-require "set"
 require "active_support/dependencies/interlock"
 module ActiveSupport # :nodoc:

data/lib/active_support/deprecation/reporting.rb CHANGED Viewed

@@ -139,7 +139,6 @@ module ActiveSupport
         def extract_callstack(callstack)
           return [] if callstack.empty?
-          return _extract_callstack(callstack) if callstack.first.is_a? String
           offending_line = callstack.find { |frame|
             # Code generated with `eval` doesn't have an `absolute_path`, e.g. templates.
@@ -150,24 +149,6 @@ module ActiveSupport
           [offending_line.path, offending_line.lineno, offending_line.label]
         end
-        def _extract_callstack(callstack)
-          ActiveSupport.deprecator.warn(<<~MESSAGE)
-            Passing the result of `caller` to ActiveSupport::Deprecation#warn is deprecated and will be removed in Rails 8.0.
-            Please pass the result of `caller_locations` instead.
-          MESSAGE
-          offending_line = callstack.find { |line| !ignored_callstack?(line) } || callstack.first
-          if offending_line
-            if md = offending_line.match(/^(.+?):(\d+)(?::in `(.*?)')?/)
-              md.captures
-            else
-              offending_line
-            end
-          end
-        end
         RAILS_GEM_ROOT = File.expand_path("../../../..", __dir__) + "/" # :nodoc:
         LIB_DIR = RbConfig::CONFIG["libdir"] # :nodoc:

data/lib/active_support/duration.rb CHANGED Viewed

@@ -491,17 +491,21 @@ module ActiveSupport
         if @parts.empty?
           time.since(sign * value)
         else
-          @parts.inject(time) do |t, (type, number)|
-            if type == :seconds
-              t.since(sign * number)
-            elsif type == :minutes
-              t.since(sign * number * 60)
-            elsif type == :hours
-              t.since(sign * number * 3600)
-            else
-              t.advance(type => sign * number)
-            end
+          @parts.each do |type, number|
+            t = time
+            time =
+              if type == :seconds
+                t.since(sign * number)
+              elsif type == :minutes
+                t.since(sign * number * 60)
+              elsif type == :hours
+                t.since(sign * number * 3600)
+              else
+                t.advance(type => sign * number)
+              end
           end
+          time
         end
       end

data/lib/active_support/evented_file_update_checker.rb CHANGED Viewed

@@ -3,7 +3,6 @@
 gem "listen", "~> 3.5"
 require "listen"
-require "set"
 require "pathname"
 require "concurrent/atomic/atomic_boolean"

data/lib/active_support/gem_version.rb CHANGED Viewed

@@ -10,7 +10,7 @@ module ActiveSupport
     MAJOR = 8
     MINOR = 0
     TINY  = 0
-    PRE   = "beta1"
+    PRE   = "rc1"
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/active_support/hash_with_indifferent_access.rb CHANGED Viewed

@@ -313,10 +313,6 @@ module ActiveSupport
     end
     alias_method :without, :except
-    def stringify_keys!; self end
-    def deep_stringify_keys!; self end
-    def stringify_keys; dup end
-    def deep_stringify_keys; dup end
     undef :symbolize_keys!
     undef :deep_symbolize_keys!
     def symbolize_keys; to_hash.symbolize_keys! end

data/lib/active_support/i18n_railtie.rb CHANGED Viewed

@@ -66,9 +66,9 @@ module I18n
       if app.config.reloading_enabled?
         directories = watched_dirs_with_extensions(reloadable_paths)
-        root_load_paths = I18n.load_path.select { |path| path.start_with?(Rails.root.to_s) }
+        root_load_paths = I18n.load_path.select { |path| path.to_s.start_with?(Rails.root.to_s) }
         reloader = app.config.file_watcher.new(root_load_paths, directories) do
-          I18n.load_path.delete_if { |p| p.start_with?(Rails.root.to_s) && !File.exist?(p) }
+          I18n.load_path.delete_if { |path| path.to_s.start_with?(Rails.root.to_s) && !File.exist?(path) }
           I18n.load_path |= reloadable_paths.flat_map(&:existent)
         end
@@ -76,7 +76,6 @@ module I18n
         app.reloader.to_run do
           reloader.execute_if_updated { require_unload_lock! }
         end
-        reloader.execute
       end
       @i18n_inited = true

data/lib/active_support/isolated_execution_state.rb CHANGED Viewed

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 module ActiveSupport
   module IsolatedExecutionState # :nodoc:
     @isolation_level = nil

data/lib/active_support/notifications/fanout.rb CHANGED Viewed

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 require "concurrent/map"
-require "set"
 require "active_support/core_ext/object/try"
 module ActiveSupport

data/lib/active_support/testing/assertions.rb CHANGED Viewed

@@ -299,17 +299,24 @@ module ActiveSupport
         end
         def _callable_to_source_string(callable)
-          if defined?(RubyVM::AbstractSyntaxTree) && callable.is_a?(Proc)
-            ast = begin
-              RubyVM::AbstractSyntaxTree.of(callable, keep_script_lines: true)
-            rescue SystemCallError
-              # Failed to get the source somehow
-              return callable
-            end
-            return callable unless ast
+          if defined?(RubyVM::InstructionSequence) && callable.is_a?(Proc)
+            iseq = RubyVM::InstructionSequence.of(callable)
+            source =
+              if iseq.script_lines
+                iseq.script_lines.join("\n")
+              elsif File.readable?(iseq.absolute_path)
+                File.read(iseq.absolute_path)
+              end
+            return callable unless source
+            location = iseq.to_a[4][:code_location]
+            return callable unless location
-            source = ast.source
-            source.strip!
+            lines = source.lines[(location[0] - 1)..(location[2] - 1)]
+            lines[-1] = lines[-1].byteslice(...location[3])
+            lines[0] = lines[0].byteslice(location[1]...)
+            source = lines.join.strip
             # We ignore procs defined with do/end as they are likely multi-line anyway.
             if source.start_with?("{")

data/lib/active_support/testing/strict_warnings.rb CHANGED Viewed

@@ -16,7 +16,7 @@ module ActiveSupport
       /Failed to validate the schema cache because/,
       # TODO: We need to decide what to do with this.
-      /Status code :unprocessable_entity is deprecated/
+      /Status code :unprocessable_entity is deprecated/,
     )
     SUPPRESSED_WARNINGS = Regexp.union(

data/lib/active_support/values/time_zone.rb CHANGED Viewed

@@ -12,7 +12,7 @@ module ActiveSupport
   # * Limit the set of zones provided by TZInfo to a meaningful subset of 134
   #   zones.
   # * Retrieve and display zones with a friendlier name
-  #   (e.g., "Eastern Time (US & Canada)" instead of "America/New_York").
+  #   (e.g., "Eastern \Time (US & Canada)" instead of "America/New_York").
   # * Lazily load +TZInfo::Timezone+ instances only when they're needed.
   # * Create ActiveSupport::TimeWithZone instances via TimeZone's +local+,
   #   +parse+, +at+, and +now+ methods.
@@ -355,7 +355,7 @@ module ActiveSupport
       "(GMT#{formatted_offset}) #{name}"
     end
-    # Method for creating new ActiveSupport::TimeWithZone instance in time zone
+    # \Method for creating new ActiveSupport::TimeWithZone instance in time zone
     # of +self+ from given values.
     #
     #   Time.zone = 'Hawaii'                    # => "Hawaii"
@@ -365,7 +365,7 @@ module ActiveSupport
       ActiveSupport::TimeWithZone.new(nil, self, time)
     end
-    # Method for creating new ActiveSupport::TimeWithZone instance in time zone
+    # \Method for creating new ActiveSupport::TimeWithZone instance in time zone
     # of +self+ from number of seconds since the Unix epoch.
     #
     #   Time.zone = 'Hawaii'        # => "Hawaii"
@@ -380,7 +380,7 @@ module ActiveSupport
       Time.at(*args).utc.in_time_zone(self)
     end
-    # Method for creating new ActiveSupport::TimeWithZone instance in time zone
+    # \Method for creating new ActiveSupport::TimeWithZone instance in time zone
     # of +self+ from an ISO 8601 string.
     #
     #   Time.zone = 'Hawaii'                     # => "Hawaii"
@@ -432,7 +432,7 @@ module ActiveSupport
       raise ArgumentError, "invalid date"
     end
-    # Method for creating new ActiveSupport::TimeWithZone instance in time zone
+    # \Method for creating new ActiveSupport::TimeWithZone instance in time zone
     # of +self+ from parsed string.
     #
     #   Time.zone = 'Hawaii'                   # => "Hawaii"
@@ -454,7 +454,7 @@ module ActiveSupport
       parts_to_time(Date._parse(str, false), now)
     end
-    # Method for creating new ActiveSupport::TimeWithZone instance in time zone
+    # \Method for creating new ActiveSupport::TimeWithZone instance in time zone
     # of +self+ from an RFC 3339 string.
     #
     #   Time.zone = 'Hawaii'                     # => "Hawaii"

data/lib/active_support.rb CHANGED Viewed

@@ -57,7 +57,6 @@ module ActiveSupport
   eager_autoload do
     autoload :BacktraceCleaner
-    autoload :ProxyObject
     autoload :Benchmark
     autoload :Benchmarkable
     autoload :Cache

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activesupport
 version: !ruby/object:Gem::Version
-  version: 8.0.0.beta1
+  version: 8.0.0.rc1
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-26 00:00:00.000000000 Z
+date: 2024-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -448,7 +448,6 @@ files:
 - lib/active_support/ordered_hash.rb
 - lib/active_support/ordered_options.rb
 - lib/active_support/parameter_filter.rb
-- lib/active_support/proxy_object.rb
 - lib/active_support/rails.rb
 - lib/active_support/railtie.rb
 - lib/active_support/reloader.rb
@@ -496,10 +495,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v8.0.0.beta1/activesupport/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v8.0.0.beta1/
+  changelog_uri: https://github.com/rails/rails/blob/v8.0.0.rc1/activesupport/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v8.0.0.rc1/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v8.0.0.beta1/activesupport
+  source_code_uri: https://github.com/rails/rails/tree/v8.0.0.rc1/activesupport
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options:

data/lib/active_support/proxy_object.rb DELETED Viewed

@@ -1,20 +0,0 @@
-# frozen_string_literal: true
-module ActiveSupport
-  class ProxyObject < ::BasicObject # :nodoc:
-    undef_method :==
-    undef_method :equal?
-    # Let ActiveSupport::ProxyObject at least raise exceptions.
-    def raise(*args)
-      ::Object.send(:raise, *args)
-    end
-    def self.inherited(_subclass)
-      ::ActiveSupport.deprecator.warn(<<~MSG)
-        ActiveSupport::ProxyObject is deprecated and will be removed in Rails 8.0.
-        Use Ruby's built-in BasicObject instead.
-      MSG
-    end
-  end
-end